DPDK: install path fixes for meson and Ubuntu 24.04 #3598
+89
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Jan 14, 2025
squirrelsc
reviewed
Jan 15, 2025
squirrelsc
reviewed
Jan 15, 2025
lisa/tools/meson.py
Outdated
| package_available = "" | ||
| for pkg in ["meson", "python3-meson"]: | ||
| if ( | ||
| posix_os.package_exists(pkg) |
There was a problem hiding this comment.
Move the implementation into check_exists, so other place can reuse it.
There was a problem hiding this comment.
I mean the package existing check, it should be done in _check_exists
squirrelsc
reviewed
Jan 15, 2025
squirrelsc
reviewed
Jan 15, 2025
| command, shell=True, sudo=True, timeout=timeout | ||
| ) | ||
|
|
||
| if install_result.exit_code == 0: |
There was a problem hiding this comment.
Assert the result to get it simpler.
squirrelsc
reviewed
Jan 17, 2025
| return self._package_exists(package_name) | ||
| exists = self._package_exists(package_name) | ||
| if exists and minimum_version: | ||
| return ( |
There was a problem hiding this comment.
It needs to print debug message, if min version is not met. It saves time to troubleshooting the reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some bugs which were noted after testing on Ubuntu 24.04: